feat(filters): add filter model with session storage #21
+231
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add FilterSettings type with type, sort and favorites-only rules * Validate stored data and fall back to defaults if it is broken * Add useFilters hook that keeps state and session storage in sync * Add tests for model and hook References #7
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #7
FilterSettingsmodel insrc/models/filters.ts(type, sort, onlyFavorites)useFiltershook insrc/controllers/that keeps state and storage in syncNothing is wired into App yet. #5 and #12 can use
useFilters()from App and passfilters/setFilterdown as props. If more rules are needed (e.g. generation) add them toFilterSettingsandparseFilters.